Add extra volume mounts to prod nginx - #689
Merged
Merged
Conversation
Matches friends deploy
ShanaLMoore
approved these changes
Aug 5, 2026
github-project-automation
Bot
moved this from Deploy to Staging
to Notch8 QA
in PalsKnapsack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
In order for the nginx reverse proxy to serve static assets, we need it to have access to them. Some are on mounts, so they need to be included on the nginx deploy as well as the Rails deploy. This matches the changes on the friends deployment.
Refs https://github.com/notch8/dev-ops/issues/1406
Expected Behavior Before Changes
Assets on the public/system path are served by Rails, taking up Puma threads
Expected Behavior After Changes
Assets on the public/system path are served by Nginx, freeing the Rails process to work on dynamic page rendering.
Notes
Difficult to see on r2-friends environments right now because of the database issues, but verified prior to the database issues.